CodSpeed Performance Report

Merging #454 will not alter performance

_{Comparing feat-improve-rpc-namespace (c36636c) with main (562f46d)}

Summary

✅ 2 untouched

Looks good. Can you search the repository for places where we have hard-coded use of rollupNode_ namespace for rpc and replace with the correct namespace? I know that there will be some cases in the sequencer-migration directory, but there may be other places as well.

All of the name of rpc methods remain unchanged. they still use rollupNode_ prefix.
Let's not forget to add --rpc.rollup-node-admin for sepolia and mainnet sequencers.

Looks good. Can you search the repository for places where we have hard-coded use of rollupNode_ namespace for rpc and replace with the correct namespace? I know that there will be some cases in the sequencer-migration directory, but there may be other places as well.

All of the name of rpc methods remain unchanged. they still use rollupNode_ prefix. Let's not forget to add --rpc.rollup-node-admin for sepolia and mainnet sequencers.

#[rpc(server, client, namespace = "rollupNodeAdmin")]
pub trait RollupNodeAdminApi {
    /// Enables automatic sequencing in the rollup node.
    #[method(name = "enableAutomaticSequencing")]
    async fn enable_automatic_sequencing(&self) -> RpcResult<bool>;

    /// Disables automatic sequencing in the rollup node.
    #[method(name = "disableAutomaticSequencing")]
    async fn disable_automatic_sequencing(&self) -> RpcResult<bool>;
}

But didn't you put these methods in the admin namespace?

Looks good. Can you search the repository for places where we have hard-coded use of rollupNode_ namespace for rpc and replace with the correct namespace? I know that there will be some cases in the sequencer-migration directory, but there may be other places as well.

All of the name of rpc methods remain unchanged. they still use rollupNode_ prefix. Let's not forget to add --rpc.rollup-node-admin for sepolia and mainnet sequencers.

#[rpc(server, client, namespace = "rollupNodeAdmin")]
pub trait RollupNodeAdminApi {
    /// Enables automatic sequencing in the rollup node.
    #[method(name = "enableAutomaticSequencing")]
    async fn enable_automatic_sequencing(&self) -> RpcResult<bool>;

    /// Disables automatic sequencing in the rollup node.
    #[method(name = "disableAutomaticSequencing")]
    async fn disable_automatic_sequencing(&self) -> RpcResult<bool>;
}

But didn't you put these methods in the admin namespace?

Oh, sorry, my mistake. yeah, will update all rollupNode_